Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use just api. in WhatsappShareButton.ts #459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SaadBazaz
Copy link

Use just api.whatsapp.com instead of choosing between api.whatsapp.com and web.whatsapp.com, because api now handles all scenarios (Web, Mobile and Desktop)

Use just api instead of web, as it now handles all scenarios
@SaadBazaz
Copy link
Author

Tested and working correctly on both mobile, desktop and WhatsApp Web.

React 18
Next 12

@matscode
Copy link

matscode commented Feb 7, 2023

This should be merged....

@matscode
Copy link

matscode commented Feb 7, 2023

I recently support merging this PR, because for some weird unknown reason; web.whatsapp.com was not accessible, but api.whatsapp.com was working. I thought whatsapp had remove the web. subdomian. so, I was thinking of forking the repo to make the change above.

Suddenly it web.whatsapp.com is now accessible. So, I don't think this PR needs to be merged anymore because the current whatsapp sharing experience is way better than what this PR would offer. Sorry @SaadBazaz. Nice effort though.

@nygardk
Copy link
Owner

nygardk commented Nov 19, 2023

Closing as stale. Please reopen if needed.

@nygardk nygardk closed this Nov 19, 2023
@SaadBazaz
Copy link
Author

@nygardk - Why I don't consider this stale:

  1. wa.me or api.whatsapp.com are the official and recommended ways of sharing to WhatsApp.
  2. web.whatsapp.com does not work for WhatsApp Desktop. It almost ALWAYS opens the web version, and most people I know have the Desktop version. The best part about api.whatsapp.com is that it first asks to open WhatsApp Desktop. If WhatsApp desktop is not present, it opens the web version. That is the best User Experience, in my opinion.

Here's a video recording of what I'm talking about.

Here's when I use web.whatsapp.com
Screenshot 2023-11-20 at 09 55 15

Here's when I use api.whatsapp.com

Screen.Recording.2023-11-20.at.09.53.14.mov

@nygardk nygardk reopened this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants